Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics for bucket store empty postings count #5721

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Sep 25, 2022

Signed-off-by: Ben Ye [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Add a new counter at bucket store for empty postings when fetch series from blocks.
It is very similar to #2030 but the metric is recorded at store gateway.
The main goal is to explore support for having something like bloom filter for each block at the store gateway level.

Verification

Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matej-g matej-g merged commit abaef5b into thanos-io:main Sep 26, 2022
@yeya24 yeya24 deleted the empty-posting-metrics branch August 28, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants